Repository navigation
Conversation
karrgov
force-pushed
the
cf_java_client_poc
branch
from
September 3, 2026 13:57
2b06745 to
698462b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Yavor16
requested changes
Sep 18, 2026
Yavor16
requested changes
Sep 18, 2026
Yavor16
requested changes
Sep 29, 2026
Yavor16
requested changes
Sep 29, 2026
theghost5800
reviewed
Oct 5, 2026
theghost5800
left a comment
theghost5800
left a comment
Contributor
There was a problem hiding this comment.
Some of comments are repeatable or not but overall do the checks through all the code again if possible
theghost5800
reviewed
Oct 5, 2026
theghost5800
left a comment
theghost5800
left a comment
Contributor
There was a problem hiding this comment.
Some of comments are repeatable or not but overall do the checks through all the code again if possible
vkalapov
reviewed
Oct 9, 2026
LMCROSSITXSADEPLOY-3563
… from poms LMCROSSITXSADEPLOY-3054
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
karrgov
force-pushed
the
cf_java_client_poc
branch
from
October 13, 2026 05:37
19c69f8 to
e7fa4e6
Compare
…operations limiting LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
LMCROSSITXSADEPLOY-3563
|
vkalapov
reviewed
Oct 30, 2026
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest</artifactId> | ||
| <version>${hamcrest.version}}</version> |
Contributor
There was a problem hiding this comment.
remove the second '}' here
Comment on lines
+229
to
+235
| private ExecutorService createUploadMonitorExecutor() { | ||
| ThreadFactory threadFactory = Thread.ofVirtual() | ||
| .name(Constants.UPLOAD_MONITOR_THREAD_NAME_PREFIX, 0) | ||
| .factory(); | ||
|
|
||
| return Executors.newThreadPerTaskExecutor(threadFactory); | ||
| } |
Contributor
There was a problem hiding this comment.
ExecutorService should be shut down as part of its owner's lifecycle. Here its created but it does not appear to be closed.
Comment on lines
+17
to
+19
| public static final int MAX_CONCURRENT_PAGES = 4; //leaving it like that for testing purposes | ||
| public static final int SECOND_PAGE = 2; | ||
| public static final int DEFAULT_CONCURRENT_TASKS = 8; //this one can be a bit more, but first tests will be like that |
Contributor
There was a problem hiding this comment.
Should these values be left for prod? If so remove the comments.
Comment on lines
+201
to
+207
| if (e.getStatusCode() == HttpStatus.NOT_FOUND) { | ||
| // package was most probably already consumed by CF between the polls, meaning that since the build was already created from the package object, the package is not needed anymore | ||
| // and the cf blobstore garbage collector has deleted it | ||
| keepPolling = false; | ||
| continue; | ||
| } | ||
| throw e; |
Contributor
There was a problem hiding this comment.
The non-404 throw runs on the background monitor thread, and it seems like the error gets swallowed. Should this call callback.onError(e) like the FAILED-status branch below?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of the cf-java-client dependency